cindex: check `say' errors w/ close or ->flush

We actually need to rely on autodie `close' to check for errors,
since error-checking with `say' is not useful due to perlio
write buffering.  We'll also stop relying on `say ... or die'
since it's needless noise.

Fixes: 19f9089343c9 (cindex: drop redundant close on regular FH)

diff --git a/lib/PublicInbox/CodeSearchIdx.pm b/lib/PublicInbox/CodeSearchIdx.pm
index 0b00c303cf9d80bcc1e25d08eec4cfbedea7c83d..5b80db4474d3a831817b65593127bdb8a4b384d3 100644 (file)
--- a/lib/PublicInbox/CodeSearchIdx.pm
+++ b/lib/PublicInbox/CodeSearchIdx.pm
@@ -468,12 +468,12 @@ sub partition_refs ($$$) {
                chomp $cmt;
                my $n = hex(substr($cmt, 0, 8)) % scalar(@RDONLY_XDB);
                if ($REINDEX && $REINDEX->set_maybe(pack('H*', $cmt), '')) {
-                       say { $shard_in[$n] } $cmt or die "say: $!";
+                       say { $shard_in[$n] } $cmt;
                        ++$NCHANGE;
                } elsif (seen($RDONLY_XDB[$n], 'Q'.$cmt)) {
                        last if ++$seen > $SEEN_MAX;
                } else {
-                       say { $shard_in[$n] } $cmt or die "say: $!";
+                       say { $shard_in[$n] } $cmt;
                        ++$NCHANGE;
                        $seen = 0;
                }
@@ -845,7 +845,7 @@ EOM
                PublicInbox::Import::init_bare($git_dir, 'cidx-all', $fmt);
                open $ALT_FH{$hexlen}, '>', "$git_dir/objects/info/alternates";
        }
-       say { $ALT_FH{$hexlen} } $objdir or die "say: $!";
+       say { $ALT_FH{$hexlen} } $objdir;
 }
 
 sub prep_alternate_start {
@@ -969,7 +969,7 @@ sub dump_git_commits { # run_await cb
        (defined($pid) && $?) and die "E: @PRUNE_BATCH: \$?=$?";
        return if $DO_QUIT;
        my ($hexlen) = keys(%ALT_FH) or return; # done
-       delete $ALT_FH{$hexlen};
+       close(delete $ALT_FH{$hexlen}); # flushes `say' buffer
 
        $PRUNE_BATCH[1] = "--git-dir=$TMPDIR/hexlen$hexlen.git";
        run_await(\@PRUNE_BATCH, undef, $batch_opt, \&dump_git_commits);