gen: Remove a pointless call to mnl_nlmsg_get_payload()

It is a common idiom in all *_nlmsg_parse() functions, but
nftnl_gen_nlmsg_parse() doesn't make use of the data pointer and the
compiler probably can't eliminate it since there could be a side-effect.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

diff --git a/src/gen.c b/src/gen.c
index 58b3a96dbdcb933e4facad08b02a71f80c96d0aa..eafb015a2534521e847056d3160daba1fd3654e6 100644 (file)
--- a/src/gen.c
+++ b/src/gen.c
@@ -143,9 +143,9 @@ static int nftnl_gen_parse_attr_cb(const struct nlattr *attr, void *data)
 int nftnl_gen_nlmsg_parse(const struct nlmsghdr *nlh, struct nftnl_gen *gen)
 {
        struct nlattr *tb[NFTA_GEN_MAX + 1] = {};
-       struct nfgenmsg *nfg = mnl_nlmsg_get_payload(nlh);
 
-       if (mnl_attr_parse(nlh, sizeof(*nfg), nftnl_gen_parse_attr_cb, tb) < 0)
+       if (mnl_attr_parse(nlh, sizeof(struct nfgenmsg),
+                          nftnl_gen_parse_attr_cb, tb) < 0)
                return -1;
 
        if (tb[NFTA_GEN_ID]) {