]> git.ipfire.org Git - thirdparty/libsolv.git/commitdiff
rules.c: Simplify if condition
authorChristoph Grüninger <foss@grueninger.de>
Wed, 14 May 2025 19:21:31 +0000 (21:21 +0200)
committerChristoph Grüninger <foss@grueninger.de>
Wed, 14 May 2025 19:21:31 +0000 (21:21 +0200)
rid <=0 is checked two lines before.
Found by Cppcheck (knownConditionTrueFalse).

src/rules.c

index cb3f9a32c40307bf8440beab64ae09be6f91d447..6b1dc037105d4ed4e4313f443d51d79f802d4cee 100644 (file)
@@ -3206,7 +3206,7 @@ solver_ruleclass(Solver *solv, Id rid)
 {
   if (rid <= 0)
     return SOLVER_RULE_UNKNOWN;
-  if (rid > 0 && rid < solv->pkgrules_end)
+  if (rid < solv->pkgrules_end)
     return SOLVER_RULE_PKG;
   if (rid >= solv->jobrules && rid < solv->jobrules_end)
     return SOLVER_RULE_JOB;