]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
smbd: fix sharing access check for directories
authorRalph Boehme <slow@samba.org>
Fri, 25 Oct 2024 15:22:57 +0000 (17:22 +0200)
committerRalph Boehme <slow@samba.org>
Tue, 29 Oct 2024 12:44:49 +0000 (12:44 +0000)
This was missing from commit 6140c3177a0330f42411618c3fca28930ea02a21 and causes
all opens of directories to be handled as stat opens, bypassing the sharemode
check.

Not adding a test at this time, as my (hopefully) soon to be merged Directory
Leases branch has a test which actually detected this problem.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15732

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Oct 29 12:44:49 UTC 2024 on atb-devel-224

source3/smbd/open.c

index 0d05bd953c0134da149f62176317cf3c4de70068..351b8f8e33e2eb79cacd076291a6c342c33be31a 100644 (file)
@@ -5447,6 +5447,7 @@ static NTSTATUS open_directory(connection_struct *conn,
                .req                    = req,
                .create_disposition     = create_disposition,
                .access_mask            = access_mask,
+               .open_access_mask       = access_mask,
                .share_access           = share_access,
                .oplock_request         = NO_OPLOCK,
                .lease                  = NULL,