]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: mediatek: mt8192: fix register configuration for tdm
authorHsin-Te Yuan <yuanhsinte@chromium.org>
Thu, 9 May 2024 07:31:29 +0000 (07:31 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Jun 2024 11:39:45 +0000 (13:39 +0200)
[ Upstream commit a85ed162f0efcfdd664954414a05d1d560cc95dc ]

For DSP_A, data is a BCK cycle behind LRCK trigger edge. For DSP_B, this
delay doesn't exist. Fix the delay configuration to match the standard.

Fixes: 52fcd65414abfc ("ASoC: mediatek: mt8192: support tdm in platform driver")
Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Link: https://lore.kernel.org/r/20240509-8192-tdm-v1-1-530b54645763@chromium.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/mediatek/mt8192/mt8192-dai-tdm.c

index f3bebed2428a72bb4b57f7748aae4c9dc05b3249..360259e60de84bd9ae387eb952e4671f5e2c67a9 100644 (file)
@@ -566,10 +566,10 @@ static int mtk_dai_tdm_hw_params(struct snd_pcm_substream *substream,
                tdm_con |= 1 << DELAY_DATA_SFT;
                tdm_con |= get_tdm_lrck_width(format) << LRCK_TDM_WIDTH_SFT;
        } else if (tdm_priv->tdm_out_mode == TDM_OUT_DSP_A) {
-               tdm_con |= 0 << DELAY_DATA_SFT;
+               tdm_con |= 1 << DELAY_DATA_SFT;
                tdm_con |= 0 << LRCK_TDM_WIDTH_SFT;
        } else if (tdm_priv->tdm_out_mode == TDM_OUT_DSP_B) {
-               tdm_con |= 1 << DELAY_DATA_SFT;
+               tdm_con |= 0 << DELAY_DATA_SFT;
                tdm_con |= 0 << LRCK_TDM_WIDTH_SFT;
        }