]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: omap4iss: return error code when omap4iss_get() failed
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 17 Nov 2020 02:50:41 +0000 (03:50 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 May 2021 08:38:23 +0000 (10:38 +0200)
[ Upstream commit 8938c48fa25b491842ece9eb38f0bea0fcbaca44 ]

If omap4iss_get() failed, it need return error code in iss_probe().

Fixes: 59f0ad807681 ("[media] v4l: omap4iss: Add support for OMAP4...")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/media/omap4iss/iss.c

index aa76ccda5b424f73f64776a010afcb9040ecd39f..130d09d28e1dc3fb1a097e0639fdca9de3d1b62b 100644 (file)
@@ -1406,8 +1406,10 @@ static int iss_probe(struct platform_device *pdev)
        if (ret < 0)
                goto error;
 
-       if (!omap4iss_get(iss))
+       if (!omap4iss_get(iss)) {
+               ret = -EINVAL;
                goto error;
+       }
 
        ret = iss_reset(iss);
        if (ret < 0)