]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu_snapshot: create: move virDomainSnapshotAssignDef to both code paths
authorPavel Hrdina <phrdina@redhat.com>
Wed, 29 Sep 2021 16:53:52 +0000 (18:53 +0200)
committerPavel Hrdina <phrdina@redhat.com>
Wed, 1 Dec 2021 11:33:31 +0000 (12:33 +0100)
This makes it obvious that the function is called for creating new
snapshot and redefining old snapshot as well.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_snapshot.c

index 6c09ab375e3d8a193a5c981bfef81dbdb235fdf4..abcee30116d8b47a0d2e54d33696bfc7ae73e1cf 100644 (file)
@@ -1760,15 +1760,18 @@ qemuSnapshotCreateXML(virDomainPtr domain,
                                           driver->xmlopt,
                                           flags) < 0)
             goto endjob;
+
+        if (!snap) {
+            if (!(snap = virDomainSnapshotAssignDef(vm->snapshots, def)))
+                goto endjob;
+        }
     } else {
         if (qemuSnapshotCreateAlignDisks(vm, def, driver, flags) < 0)
             goto endjob;
 
         if (qemuSnapshotPrepare(vm, def, &flags) < 0)
             goto endjob;
-    }
 
-    if (!snap) {
         if (!(snap = virDomainSnapshotAssignDef(vm->snapshots, def)))
             goto endjob;