platform/x86: classmate-laptop: Add missing NULL pointer checks

In a few places in the Classmate laptop driver, code using the accel
object may run before that object's address is stored in the driver
data of the input device using it.

For example, cmpc_accel_sensitivity_store_v4() is the "show" method
of cmpc_accel_sensitivity_attr_v4 which is added in cmpc_accel_add_v4(),
before calling dev_set_drvdata() for inputdev->dev.  If the sysfs
attribute is accessed prematurely, the dev_get_drvdata(&inputdev->dev)
call in in cmpc_accel_sensitivity_store_v4() returns NULL which
leads to a NULL pointer dereference going forward.

Moreover, sysfs attributes using the input device are added before
initializing that device by cmpc_add_acpi_notify_device() and if one
of them is accessed before running that function, a NULL pointer
dereference will occur.

For example, cmpc_accel_sensitivity_attr_v4 is added before calling
cmpc_add_acpi_notify_device() and if it is read prematurely, the
dev_get_drvdata(&acpi->dev) call in cmpc_accel_sensitivity_show_v4()
returns NULL which leads to a NULL pointer dereference going forward.

Fix this by adding NULL pointer checks in all of the relevant places.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/12825381.O9o76ZdvQC@rafael.j.wysocki
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
index 6b1b8e444e241cd0f0b544ecddd27f5d4c04a4f9..74d3eb83f56a634352b12bc9d71e4d25e9e3922e 100644 (file)
--- a/drivers/platform/x86/classmate-laptop.c
+++ b/drivers/platform/x86/classmate-laptop.c
@@ -207,7 +207,12 @@ static ssize_t cmpc_accel_sensitivity_show_v4(struct device *dev,
 
        acpi = to_acpi_device(dev);
        inputdev = dev_get_drvdata(&acpi->dev);
+       if (!inputdev)
+               return -ENXIO;
+
        accel = dev_get_drvdata(&inputdev->dev);
+       if (!accel)
+               return -ENXIO;
 
        return sysfs_emit(buf, "%d\n", accel->sensitivity);
 }
@@ -224,7 +229,12 @@ static ssize_t cmpc_accel_sensitivity_store_v4(struct device *dev,
 
        acpi = to_acpi_device(dev);
        inputdev = dev_get_drvdata(&acpi->dev);
+       if (!inputdev)
+               return -ENXIO;
+
        accel = dev_get_drvdata(&inputdev->dev);
+       if (!accel)
+               return -ENXIO;
 
        r = kstrtoul(buf, 0, &sensitivity);
        if (r)
@@ -256,7 +266,12 @@ static ssize_t cmpc_accel_g_select_show_v4(struct device *dev,
 
        acpi = to_acpi_device(dev);
        inputdev = dev_get_drvdata(&acpi->dev);
+       if (!inputdev)
+               return -ENXIO;
+
        accel = dev_get_drvdata(&inputdev->dev);
+       if (!accel)
+               return -ENXIO;
 
        return sysfs_emit(buf, "%d\n", accel->g_select);
 }
@@ -273,7 +288,12 @@ static ssize_t cmpc_accel_g_select_store_v4(struct device *dev,
 
        acpi = to_acpi_device(dev);
        inputdev = dev_get_drvdata(&acpi->dev);
+       if (!inputdev)
+               return -ENXIO;
+
        accel = dev_get_drvdata(&inputdev->dev);
+       if (!accel)
+               return -ENXIO;
 
        r = kstrtoul(buf, 0, &g_select);
        if (r)
@@ -302,6 +322,8 @@ static int cmpc_accel_open_v4(struct input_dev *input)
 
        acpi = to_acpi_device(input->dev.parent);
        accel = dev_get_drvdata(&input->dev);
+       if (!accel)
+               return -ENXIO;
 
        cmpc_accel_set_sensitivity_v4(acpi->handle, accel->sensitivity);
        cmpc_accel_set_g_select_v4(acpi->handle, accel->g_select);
@@ -549,7 +571,12 @@ static ssize_t cmpc_accel_sensitivity_show(struct device *dev,
 
        acpi = to_acpi_device(dev);
        inputdev = dev_get_drvdata(&acpi->dev);
+       if (!inputdev)
+               return -ENXIO;
+
        accel = dev_get_drvdata(&inputdev->dev);
+       if (!accel)
+               return -ENXIO;
 
        return sysfs_emit(buf, "%d\n", accel->sensitivity);
 }
@@ -566,7 +593,12 @@ static ssize_t cmpc_accel_sensitivity_store(struct device *dev,
 
        acpi = to_acpi_device(dev);
        inputdev = dev_get_drvdata(&acpi->dev);
+       if (!inputdev)
+               return -ENXIO;
+
        accel = dev_get_drvdata(&inputdev->dev);
+       if (!accel)
+               return -ENXIO;
 
        r = kstrtoul(buf, 0, &sensitivity);
        if (r)