]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
scsi: ufs: bsg: Delete bsg_dev when setting up bsg fails
authorGuixin Liu <kanie@linux.alibaba.com>
Wed, 18 Dec 2024 01:42:13 +0000 (09:42 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 11:50:10 +0000 (12:50 +0100)
[ Upstream commit fcf247deb3c3e1c6be5774e3fa03bbd018eff1a9 ]

We should remove the bsg device when bsg_setup_queue() fails to release the
resources.

Fixes: df032bf27a41 ("scsi: ufs: Add a bsg endpoint that supports UPIUs")
Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
Link: https://lore.kernel.org/r/20241218014214.64533-2-kanie@linux.alibaba.com
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/ufs/ufs_bsg.c

index 39bf204c6ec3e4e63e2aedce487e798f075fb1d7..16e8ddcf22fe4ab5d9d9a49e5783dda936c114e1 100644 (file)
@@ -213,6 +213,7 @@ int ufs_bsg_probe(struct ufs_hba *hba)
        q = bsg_setup_queue(bsg_dev, dev_name(bsg_dev), ufs_bsg_request, NULL, 0);
        if (IS_ERR(q)) {
                ret = PTR_ERR(q);
+               device_del(bsg_dev);
                goto out;
        }