]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: bd9571mwv: use new line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 10 Mar 2025 12:40:19 +0000 (13:40 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 17 Mar 2025 07:27:41 +0000 (08:27 +0100)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Link: https://lore.kernel.org/r/20250310-gpiochip-set-conversion-v1-5-03798bb833eb@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-bd9571mwv.c

index 9a4d55f703bb5f4a1fb41917f8f6a668db91cd4e..8df1361e3e84df251ab601d3dd088680b3b38af7 100644 (file)
@@ -72,13 +72,13 @@ static int bd9571mwv_gpio_get(struct gpio_chip *chip, unsigned int offset)
        return val & BIT(offset);
 }
 
-static void bd9571mwv_gpio_set(struct gpio_chip *chip, unsigned int offset,
+static int bd9571mwv_gpio_set(struct gpio_chip *chip, unsigned int offset,
                              int value)
 {
        struct bd9571mwv_gpio *gpio = gpiochip_get_data(chip);
 
-       regmap_update_bits(gpio->regmap, BD9571MWV_GPIO_OUT,
-                          BIT(offset), value ? BIT(offset) : 0);
+       return regmap_update_bits(gpio->regmap, BD9571MWV_GPIO_OUT,
+                                 BIT(offset), value ? BIT(offset) : 0);
 }
 
 static const struct gpio_chip template_chip = {
@@ -88,7 +88,7 @@ static const struct gpio_chip template_chip = {
        .direction_input        = bd9571mwv_gpio_direction_input,
        .direction_output       = bd9571mwv_gpio_direction_output,
        .get                    = bd9571mwv_gpio_get,
-       .set                    = bd9571mwv_gpio_set,
+       .set_rv                 = bd9571mwv_gpio_set,
        .base                   = -1,
        .ngpio                  = 2,
        .can_sleep              = true,