]> git.ipfire.org Git - thirdparty/openldap.git/commitdiff
ITS#9440 - Don't set control to NULL before it's used for output.
authorQuanah Gibson-Mount <quanah@openldap.org>
Wed, 20 Jan 2021 23:41:22 +0000 (23:41 +0000)
committerQuanah Gibson-Mount <quanah@openldap.org>
Thu, 28 Jan 2021 18:09:21 +0000 (18:09 +0000)
clients/tools/common.c

index a22949720b5c7d227f0d73b0c755329e47560eb4..1395e69a4a93b5d0c9545965925266b2fc165124 100644 (file)
@@ -730,8 +730,6 @@ tool_args( int argc, char **argv )
                                }
                                unknown_ctrls = tmpctrls;
                                ctrl.ldctl_oid = control;
-                               /* don't free it */
-                               control = NULL;
                                ctrl.ldctl_value.bv_val = NULL;
                                ctrl.ldctl_value.bv_len = 0;
                                ctrl.ldctl_iscritical = crit;
@@ -758,6 +756,8 @@ tool_args( int argc, char **argv )
                                        ctrl.ldctl_value = bv;
                                }
 
+                               /* don't free it */
+                               control = NULL;
                                unknown_ctrls[ unknown_ctrls_num ] = ctrl;
                                unknown_ctrls_num++;