printing: Slightly simplify move_driver_file_to_download_area()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>

diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c
index d5b918a569d88aaed5e9c0de13c95c8e94137e25..56fee826bd4719f5644f034ef188fb68828470f0 100644 (file)
--- a/source3/printing/nt_printing.c
+++ b/source3/printing/nt_printing.c
@@ -1427,7 +1427,11 @@ static WERROR move_driver_file_to_download_area(TALLOC_CTX *mem_ctx,
                return WERR_NOT_ENOUGH_MEMORY;
        }
 
-       if (version != -1 && (version = file_version_is_newer(conn, old_name, new_name)) > 0) {
+       if (version == -1) {
+               goto done;
+       }
+
+       if ((version = file_version_is_newer(conn, old_name, new_name)) > 0) {
                struct files_struct *dirfsp = NULL;
 
                status = driver_unix_convert(conn,
@@ -1465,6 +1469,7 @@ static WERROR move_driver_file_to_download_area(TALLOC_CTX *mem_ctx,
                }
        }
 
+done:
        ret = WERR_OK;
  out:
        TALLOC_FREE(smb_fname_old);