drm/rockchip: lvds: Fix an error handling path

[ Upstream commit 3dfa159f6b0c054eb63673fbf643a5f2cc862e63 ]

'ret' is know to be 0 a this point. Checking the return value of
'phy_init()' and 'phy_set_mode()' was intended instead.

So add the missing assignments.

Fixes: cca1705c3d89 ("drm/rockchip: lvds: Add PX30 support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/248220d4815dc8c8088cebfab7d6df5f70518438.1619881852.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c
index 654bc52d9ff39f2ab4032ea805cb95c920b2265f..1a7f24c1ce495630a7aa7dc75f315f4df77dc7e5 100644 (file)
--- a/drivers/gpu/drm/rockchip/rockchip_lvds.c
+++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c
@@ -499,11 +499,11 @@ static int px30_lvds_probe(struct platform_device *pdev,
        if (IS_ERR(lvds->dphy))
                return PTR_ERR(lvds->dphy);
 
-       phy_init(lvds->dphy);
+       ret = phy_init(lvds->dphy);
        if (ret)
                return ret;
 
-       phy_set_mode(lvds->dphy, PHY_MODE_LVDS);
+       ret = phy_set_mode(lvds->dphy, PHY_MODE_LVDS);
        if (ret)
                return ret;