Accidently, the other review parts were committed on the review #2 commit:
review #3: Update changelog with create nsec3 fix
review #4: be consistent when printing ldns_calc_keytag() (made all %u and casted to (unsigned int))
characters in dnames
*/
c = (unsigned char) data[src_pos];
- if(data[src_pos]=='.' || data[src_pos]==';' ||
- data[src_pos]=='(' || data[src_pos]==')' ||
- data[src_pos]=='\\') {
+ if(c == '.' || c == ';' ||
+ c == '(' || c == ')' ||
+ c == '\\') {
ldns_buffer_printf(output, "\\%c",
data[src_pos]);
} else if (!(isascii(c) && isgraph(c))) {