]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
staging: ion: Prevent incorrect reference counting behavour
authorLee Jones <lee.jones@linaro.org>
Mon, 25 Apr 2022 15:51:54 +0000 (16:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Apr 2022 11:53:57 +0000 (13:53 +0200)
Supply additional check in order to prevent unexpected results.

Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf")
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/android/ion/ion.c

index e1fe03ceb7f13cf577e608c5e9664c1bcda3368a..e6d4a3ee6cda5fada4c91939238f8d6a502b74a5 100644 (file)
@@ -114,6 +114,9 @@ static void *ion_buffer_kmap_get(struct ion_buffer *buffer)
        void *vaddr;
 
        if (buffer->kmap_cnt) {
+               if (buffer->kmap_cnt == INT_MAX)
+                       return ERR_PTR(-EOVERFLOW);
+
                buffer->kmap_cnt++;
                return buffer->vaddr;
        }