Remove undefined operations

diff --git a/ChangeLog b/ChangeLog
index 37579f52bb1d7f01d61c2ec780617fc6c92bf801..29c0c032c872d961ed74dc8b6bd77ad7c87e7c00 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2010-07-18  Andreas Schwab  <schwab@linux-m68k.org>
+
+       * debug/vdprintf_chk.c (__vdprintf_chk): Remove undefined
+       operation.
+       * libio/iofdopen.c (_IO_new_fdopen): Likewise.
+       * libio/iofopncook.c (_IO_cookie_init): Likewise.
+       * libio/iovdprintf.c (_IO_vdprintf): Likewise.
+       * libio/oldiofdopen.c (_IO_old_fdopen): Likewise.
+       * sysdeps/powerpc/powerpc64/dl-machine.h (elf_machine_rela):
+       Likewise.
+
 2010-07-09  Ulrich Drepper  <drepper@redhat.com>
 
        * sysdeps/unix/sysv/linux/fpathconf.c (__fpathconf): Use __fcntl not

diff --git a/debug/vdprintf_chk.c b/debug/vdprintf_chk.c
index 8f3d332a40d362050591e912d542dc2d7e5e43f1..e65fbe802c22b21b4d82715687da59a42872a555 100644 (file)
--- a/debug/vdprintf_chk.c
+++ b/debug/vdprintf_chk.c
@@ -50,10 +50,10 @@ __vdprintf_chk (int d, int flags, const char *format, va_list arg)
       INTUSE(_IO_un_link) (&tmpfil);
       return EOF;
     }
-  tmpfil.file._IO_file_flags =
-    (_IO_mask_flags (&tmpfil.file, _IO_NO_READS,
-                    _IO_NO_READS+_IO_NO_WRITES+_IO_IS_APPENDING)
-     | _IO_DELETE_DONT_CLOSE);
+  tmpfil.file._flags |= _IO_DELETE_DONT_CLOSE;
+
+  _IO_mask_flags (&tmpfil.file, _IO_NO_READS,
+                 _IO_NO_READS+_IO_NO_WRITES+_IO_IS_APPENDING);
 
   /* For flags > 0 (i.e. __USE_FORTIFY_LEVEL > 1) request that %n
      can only come from read-only format strings.  */

diff --git a/libio/iofdopen.c b/libio/iofdopen.c
index 0c449ed75b4b91b4791f1399b141a984d1a9af26..85430450f588365371be3d1a24cd3c7cab2deb12 100644 (file)
--- a/libio/iofdopen.c
+++ b/libio/iofdopen.c
@@ -172,9 +172,8 @@ _IO_new_fdopen (fd, mode)
     }
   new_f->fp.file._flags &= ~_IO_DELETE_DONT_CLOSE;
 
-  new_f->fp.file._IO_file_flags =
-    _IO_mask_flags (&new_f->fp.file, read_write,
-                   _IO_NO_READS+_IO_NO_WRITES+_IO_IS_APPENDING);
+  _IO_mask_flags (&new_f->fp.file, read_write,
+                 _IO_NO_READS+_IO_NO_WRITES+_IO_IS_APPENDING);
 
   return &new_f->fp.file;
 }

diff --git a/libio/iofopncook.c b/libio/iofopncook.c
index 976ff5093a007b266dd6c4894b8e6df0d71abe48..b06429d7699fcee85512dce10e26c9babf841a54 100644 (file)
--- a/libio/iofopncook.c
+++ b/libio/iofopncook.c
@@ -154,9 +154,8 @@ _IO_cookie_init (struct _IO_cookie_file *cfile, int read_write,
 
   INTUSE(_IO_file_init) (&cfile->__fp);
 
-  cfile->__fp.file._IO_file_flags =
-    _IO_mask_flags (&cfile->__fp.file, read_write,
-                   _IO_NO_READS+_IO_NO_WRITES+_IO_IS_APPENDING);
+  _IO_mask_flags (&cfile->__fp.file, read_write,
+                 _IO_NO_READS+_IO_NO_WRITES+_IO_IS_APPENDING);
 
   /* We use a negative number different from -1 for _fileno to mark that
      this special stream is not associated with a real file, but still has

diff --git a/libio/iovdprintf.c b/libio/iovdprintf.c
index 5284ff89380bd9aef6864fe6f2b7dc77feb6dc5d..fb4a838a53b48dff1f1d06ce541ece6b88639c81 100644 (file)
--- a/libio/iovdprintf.c
+++ b/libio/iovdprintf.c
@@ -53,10 +53,10 @@ _IO_vdprintf (d, format, arg)
       INTUSE(_IO_un_link) (&tmpfil);
       return EOF;
     }
-  tmpfil.file._IO_file_flags =
-    (_IO_mask_flags (&tmpfil.file, _IO_NO_READS,
-                    _IO_NO_READS+_IO_NO_WRITES+_IO_IS_APPENDING)
-     | _IO_DELETE_DONT_CLOSE);
+  tmpfil.file._flags |= _IO_DELETE_DONT_CLOSE;
+
+  _IO_mask_flags (&tmpfil.file, _IO_NO_READS,
+                 _IO_NO_READS+_IO_NO_WRITES+_IO_IS_APPENDING);
 
   done = INTUSE(_IO_vfprintf) (&tmpfil.file, format, arg);
 

diff --git a/libio/oldiofdopen.c b/libio/oldiofdopen.c
index c616b387fa47de38c91c2f7e37fd6e3ccfab439d..a1fc6675a4d4bd07809bf43526a26989c93368e0 100644 (file)
--- a/libio/oldiofdopen.c
+++ b/libio/oldiofdopen.c
@@ -130,9 +130,8 @@ _IO_old_fdopen (fd, mode)
     }
   new_f->fp.file._file._flags &= ~_IO_DELETE_DONT_CLOSE;
 
-  new_f->fp.file._file._IO_file_flags =
-    _IO_mask_flags (&new_f->fp.file._file, read_write,
-                   _IO_NO_READS+_IO_NO_WRITES+_IO_IS_APPENDING);
+  _IO_mask_flags (&new_f->fp.file._file, read_write,
+                 _IO_NO_READS+_IO_NO_WRITES+_IO_IS_APPENDING);
 
   return (_IO_FILE *) &new_f->fp;
 }

diff --git a/sysdeps/powerpc/powerpc64/dl-machine.h b/sysdeps/powerpc/powerpc64/dl-machine.h
index 00888587affd457266b859858d8924f47bfbade8..0892b1d9df8b5b7c196efb6d4dd4021d71ce4ba7 100644 (file)
--- a/sysdeps/powerpc/powerpc64/dl-machine.h
+++ b/sysdeps/powerpc/powerpc64/dl-machine.h
@@ -641,16 +641,14 @@ elf_machine_rela (struct link_map *map,
       value = elf_machine_tprel (map, sym_map, sym, reloc);
       if (dont_expect ((value & 3) != 0))
         _dl_reloc_overflow (map, "R_PPC64_TPREL16_LO_DS", reloc_addr, refsym);
-      *(Elf64_Half *) reloc_addr = BIT_INSERT (*(Elf64_Half *) reloc_addr,
-                                              value, 0xfffc);
+      BIT_INSERT (*(Elf64_Half *) reloc_addr, value, 0xfffc);
       break;
 
     case R_PPC64_TPREL16_DS:
       value = elf_machine_tprel (map, sym_map, sym, reloc);
       if (dont_expect ((value + 0x8000) >= 0x10000 || (value & 3) != 0))
         _dl_reloc_overflow (map, "R_PPC64_TPREL16_DS", reloc_addr, refsym);
-      *(Elf64_Half *) reloc_addr = BIT_INSERT (*(Elf64_Half *) reloc_addr,
-                                              value, 0xfffc);
+      BIT_INSERT (*(Elf64_Half *) reloc_addr, value, 0xfffc);
       break;
 
     case R_PPC64_TPREL16: