drm/logicvc: Fix device node reference leak in logicvc_drm_config_parse()

The logicvc_drm_config_parse() function calls of_get_child_by_name() to
find the "layers" node but fails to release the reference, leading to a
device node reference leak.

Fix this by using the __free(device_node) cleanup attribute to automatic
release the reference when the variable goes out of scope.

Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Link: https://patch.msgid.link/20260130-logicvc_drm-v1-1-04366463750c@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c
index 204b0fee55d0b2ef1066571ad3a9241f03474a64..bbebf4fc7f51a8b3b70d8361faf36e8aa0938ad4 100644 (file)
--- a/drivers/gpu/drm/logicvc/logicvc_drm.c
+++ b/drivers/gpu/drm/logicvc/logicvc_drm.c
@@ -92,7 +92,6 @@ static int logicvc_drm_config_parse(struct logicvc_drm *logicvc)
        struct device *dev = drm_dev->dev;
        struct device_node *of_node = dev->of_node;
        struct logicvc_drm_config *config = &logicvc->config;
-       struct device_node *layers_node;
        int ret;
 
        logicvc_of_property_parse_bool(of_node, LOGICVC_OF_PROPERTY_DITHERING,
@@ -128,7 +127,8 @@ static int logicvc_drm_config_parse(struct logicvc_drm *logicvc)
        if (ret)
                return ret;
 
-       layers_node = of_get_child_by_name(of_node, "layers");
+       struct device_node *layers_node __free(device_node) =
+               of_get_child_by_name(of_node, "layers");
        if (!layers_node) {
                drm_err(drm_dev, "Missing non-optional layers node\n");
                return -EINVAL;