]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: amlogic: phy-meson-axg-pcie: Simplify error handling with dev_err_probe()
authorAnand Moon <linux.amoon@gmail.com>
Thu, 10 Apr 2025 13:33:20 +0000 (19:03 +0530)
committerVinod Koul <vkoul@kernel.org>
Fri, 11 Apr 2025 11:37:15 +0000 (17:07 +0530)
Use dev_err_probe() for phy resources to indicate the deferral
reason when waiting for the resource to come up.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20250410133332.294556-6-linux.amoon@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/amlogic/phy-meson-axg-pcie.c

index 60be5cdc600b32a093a7286240caa000eaf66ab6..54baf7b8930e1d8c1d9bdf26dd1e9443be5e6292 100644 (file)
@@ -131,19 +131,15 @@ static int phy_axg_pcie_probe(struct platform_device *pdev)
        struct phy_axg_pcie_priv *priv;
        struct device_node *np = dev->of_node;
        void __iomem *base;
-       int ret;
 
        priv = devm_kmalloc(dev, sizeof(*priv), GFP_KERNEL);
        if (!priv)
                return -ENOMEM;
 
        priv->phy = devm_phy_create(dev, np, &phy_axg_pcie_ops);
-       if (IS_ERR(priv->phy)) {
-               ret = PTR_ERR(priv->phy);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(dev, "failed to create PHY\n");
-               return ret;
-       }
+       if (IS_ERR(priv->phy))
+               return dev_err_probe(dev, PTR_ERR(priv->phy),
+                                    "failed to create PHY\n");
 
        base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(base))