]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gpio: wcd934x: check the return value of regmap_update_bits()
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 9 Jul 2025 06:41:39 +0000 (08:41 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 15 Jul 2025 07:54:41 +0000 (09:54 +0200)
regmap_update_bits() can fail so check its return value in
wcd_gpio_direction_output() for consistency with the rest of the code
and propagate any errors.

Link: https://lore.kernel.org/r/20250709-gpiochip-set-rv-gpio-remaining-v1-2-b8950f69618d@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-wcd934x.c

index 2bba27b13947f14459c32db4812f6451eddbbfe4..cfa7b0a50c8e339603bc5fc70a8d7354f3bc6486 100644 (file)
@@ -46,9 +46,12 @@ static int wcd_gpio_direction_output(struct gpio_chip *chip, unsigned int pin,
                                     int val)
 {
        struct wcd_gpio_data *data = gpiochip_get_data(chip);
+       int ret;
 
-       regmap_update_bits(data->map, WCD_REG_DIR_CTL_OFFSET,
-                          WCD_PIN_MASK(pin), WCD_PIN_MASK(pin));
+       ret = regmap_update_bits(data->map, WCD_REG_DIR_CTL_OFFSET,
+                                WCD_PIN_MASK(pin), WCD_PIN_MASK(pin));
+       if (ret)
+               return ret;
 
        return regmap_update_bits(data->map, WCD_REG_VAL_CTL_OFFSET,
                                  WCD_PIN_MASK(pin),