wifi: ath11k: fix memory leaks in beacon template setup

The functions ath11k_mac_setup_bcn_tmpl_ema() and
ath11k_mac_setup_bcn_tmpl_mbssid() allocate memory for beacon templates
but fail to free it when parameter setup returns an error.

Since beacon templates must be released during normal execution, they
must also be released in the error handling paths to prevent memory
leaks.

Fix this by using unified exit paths with proper cleanup in the respective
error paths.

Compile tested only. Issue found using a prototype static analysis tool
and code review.

Fixes: 3a415daa3e8b ("wifi: ath11k: add P2P IE in beacon template")
Fixes: 335a92765d30 ("wifi: ath11k: MBSSID beacon support")
Suggested-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Link: https://patch.msgid.link/20260130084451.110768-1-zilin@seu.edu.cn
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>

diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 4dfd08b584164e6c7bc81c0b877fc8218f7086ce..e872f416ea97bceb6707f8050083b7632393eab3 100644 (file)
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -1557,12 +1557,15 @@ static int ath11k_mac_setup_bcn_tmpl_ema(struct ath11k_vif *arvif,
        if (!beacons || !beacons->cnt) {
                ath11k_warn(arvif->ar->ab,
                            "failed to get ema beacon templates from mac80211\n");
-               return -EPERM;
+               ret = -EPERM;
+               goto free;
        }
 
        if (tx_arvif == arvif) {
-               if (ath11k_mac_set_vif_params(tx_arvif, beacons->bcn[0].skb))
-                       return -EINVAL;
+               if (ath11k_mac_set_vif_params(tx_arvif, beacons->bcn[0].skb)) {
+                       ret = -EINVAL;
+                       goto free;
+               }
        } else {
                arvif->wpaie_present = tx_arvif->wpaie_present;
        }
@@ -1589,11 +1592,11 @@ static int ath11k_mac_setup_bcn_tmpl_ema(struct ath11k_vif *arvif,
                }
        }
 
-       ieee80211_beacon_free_ema_list(beacons);
-
        if (tx_arvif != arvif && !nontx_vif_params_set)
-               return -EINVAL; /* Profile not found in the beacons */
+               ret = -EINVAL; /* Profile not found in the beacons */
 
+free:
+       ieee80211_beacon_free_ema_list(beacons);
        return ret;
 }
 
@@ -1622,19 +1625,22 @@ static int ath11k_mac_setup_bcn_tmpl_mbssid(struct ath11k_vif *arvif,
        }
 
        if (tx_arvif == arvif) {
-               if (ath11k_mac_set_vif_params(tx_arvif, bcn))
-                       return -EINVAL;
+               if (ath11k_mac_set_vif_params(tx_arvif, bcn)) {
+                       ret = -EINVAL;
+                       goto free;
+               }
        } else if (!ath11k_mac_set_nontx_vif_params(tx_arvif, arvif, bcn)) {
-               return -EINVAL;
+               ret = -EINVAL;
+               goto free;
        }
 
        ret = ath11k_wmi_bcn_tmpl(ar, arvif->vdev_id, &offs, bcn, 0);
-       kfree_skb(bcn);
-
        if (ret)
                ath11k_warn(ab, "failed to submit beacon template command: %d\n",
                            ret);
 
+free:
+       kfree_skb(bcn);
        return ret;
 }