]> git.ipfire.org Git - thirdparty/Chart.js.git/commitdiff
Fix drawing angle lines on reversed radial scale (#11788)
authorJacco van den Berg <jaccoberg2281@gmail.com>
Fri, 24 May 2024 14:15:28 +0000 (16:15 +0200)
committerGitHub <noreply@github.com>
Fri, 24 May 2024 14:15:28 +0000 (16:15 +0200)
* Fix drawing angle lines on reversed radial scale

* add test

* Show ticks in test

---------

Co-authored-by: Jacco van den Berg <jacco@jem-id.nl>
src/scales/scale.radialLinear.js
test/fixtures/scale.radialLinear/anglelines-reverse-scale.js [new file with mode: 0644]
test/fixtures/scale.radialLinear/anglelines-reverse-scale.png [new file with mode: 0644]

index 1e3f796909386c21358f80f06b870bb0b0c526e2..642fa1c140f46fbd3abe83f861d4f34e46495814 100644 (file)
@@ -606,7 +606,7 @@ export default class RadialLinearScale extends LinearScaleBase {
         ctx.setLineDash(optsAtIndex.borderDash);
         ctx.lineDashOffset = optsAtIndex.borderDashOffset;
 
-        offset = this.getDistanceFromCenterForValue(opts.ticks.reverse ? this.min : this.max);
+        offset = this.getDistanceFromCenterForValue(opts.reverse ? this.min : this.max);
         position = this.getPointPosition(i, offset);
         ctx.beginPath();
         ctx.moveTo(this.xCenter, this.yCenter);
diff --git a/test/fixtures/scale.radialLinear/anglelines-reverse-scale.js b/test/fixtures/scale.radialLinear/anglelines-reverse-scale.js
new file mode 100644 (file)
index 0000000..af35a68
--- /dev/null
@@ -0,0 +1,35 @@
+module.exports = {
+  config: {
+    type: 'radar',
+    data: {
+      labels: ['A', 'B', 'C', 'D', 'E'],
+      datasets: [{
+        data: [1, 1, 2, 3, 5]
+      }]
+    },
+    options: {
+      responsive: false,
+      scales: {
+        r: {
+          reverse: true,
+          grid: {
+            display: true,
+          },
+          angleLines: {
+            color: 'red',
+            lineWidth: 5,
+          },
+          pointLabels: {
+            display: false
+          },
+          ticks: {
+            display: true,
+          }
+        }
+      }
+    }
+  },
+  options: {
+    spriteText: true,
+  }
+};
diff --git a/test/fixtures/scale.radialLinear/anglelines-reverse-scale.png b/test/fixtures/scale.radialLinear/anglelines-reverse-scale.png
new file mode 100644 (file)
index 0000000..f2367b9
Binary files /dev/null and b/test/fixtures/scale.radialLinear/anglelines-reverse-scale.png differ