]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
wpa_cli: Don't access uninitialized variables
authorAndrei Otcheretianski <andrei.otcheretianski@intel.com>
Mon, 19 Oct 2020 08:06:28 +0000 (11:06 +0300)
committerJouni Malinen <j@w1.fi>
Mon, 19 Oct 2020 20:01:11 +0000 (23:01 +0300)
Don't print potentially uninitialized variables in wpa_ctrl_command_bss().
Some compilers and analyzers may warn about it.

Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
wpa_supplicant/wpa_cli.c

index 51c9642e9023c77ac50be9b12877fec8fb215f31..813e4b3cfda4ae6e8d042f0c51f881e596f36038 100644 (file)
@@ -3085,7 +3085,8 @@ static int wpa_cli_cmd_dpp_stop_chirp(struct wpa_ctrl *ctrl, int argc,
 
 static int wpa_ctrl_command_bss(struct wpa_ctrl *ctrl, const char *cmd)
 {
-       char buf[512], *pos, *bssid, *freq, *level, *flags, *ssid;
+       char buf[512], *pos, *bssid = NULL, *freq = NULL, *level = NULL,
+               *flags = NULL, *ssid = NULL;
        size_t len;
        int ret, id = -1;
 
@@ -3126,7 +3127,9 @@ static int wpa_ctrl_command_bss(struct wpa_ctrl *ctrl, const char *cmd)
                *pos++ = '\0';
        }
        if (id != -1)
-               printf("%s\t%s\t%s\t%s\t%s\n", bssid, freq, level, flags, ssid);
+               printf("%s\t%s\t%s\t%s\t%s\n", bssid ? bssid : "N/A",
+                      freq ? freq : "N/A", level ? level : "N/A",
+                      flags ? flags : "N/A", ssid ? ssid : "N/A");
        return id;
 }