]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Input: aiptek - use HID headers
authorOliver Neukum <oneukum@suse.com>
Wed, 25 Mar 2026 14:32:46 +0000 (15:32 +0100)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 25 Mar 2026 16:09:51 +0000 (09:09 -0700)
The driver uses its own definitions for HID requests.
This leads to duplication and obfuscation. Use HID's
definitions.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Link: https://patch.msgid.link/20260325143256.371854-1-oneukum@suse.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/tablet/aiptek.c

index 6df24cee3c9d48c6fb211e850cd71efab40d5eec..1ad3c19aa155debd7608301f4ad3c694d52d0b24 100644 (file)
@@ -57,6 +57,7 @@
  *      http://aiptektablet.sourceforge.net.
  */
 
+#include <linux/hid.h>
 #include <linux/jiffies.h>
 #include <linux/kernel.h>
 #include <linux/slab.h>
 
 #define USB_VENDOR_ID_AIPTEK                           0x08ca
 #define USB_VENDOR_ID_KYE                              0x0458
-#define USB_REQ_GET_REPORT                             0x01
-#define USB_REQ_SET_REPORT                             0x09
 
        /* PointerMode codes
         */
@@ -856,7 +855,7 @@ aiptek_set_report(struct aiptek *aiptek,
 
        return usb_control_msg(udev,
                               usb_sndctrlpipe(udev, 0),
-                              USB_REQ_SET_REPORT,
+                              HID_REQ_SET_REPORT,
                               USB_TYPE_CLASS | USB_RECIP_INTERFACE |
                               USB_DIR_OUT, (report_type << 8) + report_id,
                               aiptek->ifnum, buffer, size, 5000);
@@ -871,7 +870,7 @@ aiptek_get_report(struct aiptek *aiptek,
 
        return usb_control_msg(udev,
                               usb_rcvctrlpipe(udev, 0),
-                              USB_REQ_GET_REPORT,
+                              HID_REQ_GET_REPORT,
                               USB_TYPE_CLASS | USB_RECIP_INTERFACE |
                               USB_DIR_IN, (report_type << 8) + report_id,
                               aiptek->ifnum, buffer, size, 5000);