]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
hwmon: (max6697) fix regmap leak on probe failure
authorJohan Hovold <johan@kernel.org>
Thu, 27 Nov 2025 13:43:51 +0000 (14:43 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 Jan 2026 11:57:30 +0000 (12:57 +0100)
commit 02f0ad8e8de8cf5344f8f0fa26d9529b8339da47 upstream.

The i2c regmap allocated during probe is never freed.

Switch to using the device managed allocator so that the regmap is
released on probe failures (e.g. probe deferral) and on driver unbind.

Fixes: 3a2a8cc3fe24 ("hwmon: (max6697) Convert to use regmap")
Cc: stable@vger.kernel.org # 6.12
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20251127134351.1585-1-johan@kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwmon/max6697.c

index 0735a1d2c20fdce1bd349a3352339a935ca2471a..6926d787b5ad12b62d3822f10a4004630a873dc9 100644 (file)
@@ -548,7 +548,7 @@ static int max6697_probe(struct i2c_client *client)
        struct regmap *regmap;
        int err;
 
-       regmap = regmap_init_i2c(client, &max6697_regmap_config);
+       regmap = devm_regmap_init_i2c(client, &max6697_regmap_config);
        if (IS_ERR(regmap))
                return PTR_ERR(regmap);