]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[2225_statistics_3] change assertGreater() to assertGreaterEqual()
authorNaoki Kambe <kambe@jprs.co.jp>
Wed, 6 Feb 2013 00:19:05 +0000 (09:19 +0900)
committerNaoki Kambe <kambe@jprs.co.jp>
Wed, 6 Feb 2013 00:30:13 +0000 (09:30 +0900)
http://git.bind10.isc.org/~tester/builder//BIND10-cppcheck/20130129171501-FreeBSD8-amd64-GCC/logs/unittests.out
http://git.bind10.isc.org/~tester/builder//BIND10-cppcheck/20130205115001-FreeBSD8-amd64-GCC/logs/unittests.out

As the above results, on this platform, it doesn't mostly return an
accurate float of seconds which is less than 1.0. The above failure
happened at line 203 in counters_test.py , but also at line 142 there
is probably the same problem.  This fix is similar to
89fd37be8d063c6fce0fa731ab7f3ac9c45667ef.

src/lib/python/isc/statistics/tests/counters_test.py

index 550fd1f9a936444a347d521c9a9d60536431c4cb..2d791c4318caa60ac96af54d2e22a1b709b7bdc2 100644 (file)
@@ -139,9 +139,9 @@ class TestBasicMethods(unittest.TestCase):
             counters._get_counter(self.counters._statistics._data,
                                  counter_name),
             concurrency * number)
-        self.assertGreater(
+        self.assertGreaterEqual(
             counters._get_counter(self.counters._statistics._data,
-                                 timer_name), 0)
+                                 timer_name), 0.0)
 
     def test_concat(self):
         # only strings
@@ -200,7 +200,7 @@ class BaseTestCounters():
             if name.find('time_to_') == 0:
                 self.counters.start_timer(*args)
                 self.counters.stop_timer(*args)
-                self.assertGreater(self.counters.get(*args), 0)
+                self.assertGreaterEqual(self.counters.get(*args), 0.0)
                 sec = self.counters.get(*args)
                 for zone_str in (self._entire_server, TEST_ZONE_NAME_STR):
                     isc.cc.data.set(self._statistics_data,