]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mm/damon/tests/core-kunit: handle alloc failures in damon_test_ops_registration()
authorSeongJae Park <sj@kernel.org>
Sat, 1 Nov 2025 18:20:03 +0000 (11:20 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2026 09:14:48 +0000 (10:14 +0100)
commit 4f835f4e8c863985f15abd69db033c2f66546094 upstream.

damon_test_ops_registration() is assuming all dynamic memory allocation in
it will succeed.  Those are indeed likely in the real use cases since
those allocations are too small to fail, but theoretically those could
fail.  In the case, inappropriate memory access can happen.  Fix it by
appropriately cleanup pre-allocated memory and skip the execution of the
remaining tests in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-10-sj@kernel.org
Fixes: 4f540f5ab4f2 ("mm/damon/core-test: add a kunit test case for ops registration")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [5.19+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mm/damon/tests/core-kunit.h

index 60226658503f92c159662610cbeb4da445295e16..a50241680cc4b4ebe046f5e554782d9e9c37b885 100644 (file)
@@ -300,6 +300,9 @@ static void damon_test_ops_registration(struct kunit *test)
        struct damon_operations ops = {.id = DAMON_OPS_VADDR}, bak;
        bool need_cleanup = false;
 
+       if (!c)
+               kunit_skip(test, "ctx alloc fail");
+
        /* DAMON_OPS_VADDR is registered only if CONFIG_DAMON_VADDR is set */
        if (!damon_is_registered_ops(DAMON_OPS_VADDR)) {
                bak.id = DAMON_OPS_VADDR;