Fixes to various issues reported by pyflakes

Pyflake is a python (2) source checker. This patch fixes various
(mostly trivial) errors and warnings it reports.

Change-Id: Ia35c5ac61751b927814cf693994c632c412386ea

diff --git a/build_tools/get_documentation.py b/build_tools/get_documentation.py
index 2ff4cb2b9470a7e123d53891839677979ba78025..3211896460c5bf03d3fbd3957537f88714ae8bb9 100644 (file)
--- a/build_tools/get_documentation.py
+++ b/build_tools/get_documentation.py
@@ -9,11 +9,8 @@ the GNU General Public License Version 2.
 '''
 
 import sys
-import os
 import xml.dom.minidom
 
-from xml.dom.minidom import Element
-
 
 def get_manager_event_method_type(candidate_string):
     if "ast_manager_event_multichan" in candidate_string:

diff --git a/build_tools/post_process_documentation.py b/build_tools/post_process_documentation.py
index 5fa1c5b587f69d87e05239bc82f0cdba73963c67..c1496beabf963531d913cb7f754811466281fe75 100644 (file)
--- a/build_tools/post_process_documentation.py
+++ b/build_tools/post_process_documentation.py
@@ -9,11 +9,9 @@ the GNU General Public License Version 2.
 '''
 
 import sys
-import os
 import optparse
-import xml.dom.minidom
 
-from xml.dom.minidom import Element, parse
+from xml.dom.minidom import parse
 
 
 def merge_parameter_information(managerEvent):

diff --git a/contrib/ast-db-manage/config/versions/4c573e7135bd_fix_tos_field_types.py b/contrib/ast-db-manage/config/versions/4c573e7135bd_fix_tos_field_types.py
index 27b498f30a76ed8a4365c3a5b72d9d3ba9f20d50..17906ae19da8a4d2c10a3f67d9d0e7c036312934 100755 (executable)
--- a/contrib/ast-db-manage/config/versions/4c573e7135bd_fix_tos_field_types.py
+++ b/contrib/ast-db-manage/config/versions/4c573e7135bd_fix_tos_field_types.py
@@ -11,7 +11,6 @@ revision = '4c573e7135bd'
 down_revision = '28887f25a46f'
 
 from alembic import op
-from alembic import context
 import sqlalchemy as sa
 from sqlalchemy.dialects.postgresql import ENUM
 

diff --git a/contrib/ast-db-manage/config/versions/5139253c0423_make_q_member_uniqueid_autoinc.py b/contrib/ast-db-manage/config/versions/5139253c0423_make_q_member_uniqueid_autoinc.py
index 01d4985fe5e9e51f43c86627de137d84636deaa5..72f5ee169615b051312d5427017ace299571f243 100755 (executable)
--- a/contrib/ast-db-manage/config/versions/5139253c0423_make_q_member_uniqueid_autoinc.py
+++ b/contrib/ast-db-manage/config/versions/5139253c0423_make_q_member_uniqueid_autoinc.py
@@ -33,7 +33,6 @@ import sqlalchemy as sa
 
 
 def upgrade():
-    context = op.get_context()
     # Was unable to find a way to use op.alter_column() to add the unique
     # index property.
     op.drop_column('queue_members', 'uniqueid')

diff --git a/rest-api-templates/asterisk_processor.py b/rest-api-templates/asterisk_processor.py
index 68a6799946b63657cc743fff9674b4fcfdda1167..981294673079966cf71ab3d24e648988b8e693aa 100644 (file)
--- a/rest-api-templates/asterisk_processor.py
+++ b/rest-api-templates/asterisk_processor.py
@@ -20,6 +20,7 @@
 Asterisk RESTful HTTP binding code.
 """
 
+import os
 import re
 
 from swagger_model import *

diff --git a/rest-api-templates/swagger_model.py b/rest-api-templates/swagger_model.py
index c71352a01254ab456c51739a39665c98b24ca7e8..08852415c00eb658e7114ce2852db17775cca7f8 100644 (file)
--- a/rest-api-templates/swagger_model.py
+++ b/rest-api-templates/swagger_model.py
@@ -737,7 +737,7 @@ class ResourceListing(Stringify):
         self.swagger_version = resources_json.get('swaggerVersion')
         if not self.swagger_version in SWAGGER_VERSIONS:
             raise SwaggerError(
-                "Unsupported Swagger version %s" % swagger_version, context)
+                "Unsupported Swagger version %s" % self.swagger_version, context)
 
         validate_required_fields(resources_json, self.required_fields, context)
         self.api_version = resources_json['apiVersion']

diff --git a/rest-api-templates/transform.py b/rest-api-templates/transform.py
index fc12efe85938107a8810009519858d785f83b735..c3a0300640503a4bea8e1535b6eb7d90fa0c9601 100644 (file)
--- a/rest-api-templates/transform.py
+++ b/rest-api-templates/transform.py
@@ -52,7 +52,6 @@ class Transform(object):
         dest_exists = os.path.exists(dest_file)
         if dest_exists and not self.overwrite:
             return
-        tmp_file = tempfile.mkstemp()
         with tempfile.NamedTemporaryFile() as out:
             out.write(renderer.render(self.template, model))
             out.flush()