taskprocessor: Fix race condition between unreferencing and finding.

When unreferencing a taskprocessor its reference count is checked
to determine if it should be unlinked from the taskprocessors
container and its listener shut down. In between the time when the
reference count is checked and unlinking it is possible for
another thread to jump in, find it, and get a reference to it. If
the thread then uses the taskprocessor it may find that it is not
in the state it expects.

This change locks the taskprocessors container during almost the
entire unreference operation to ensure that any other thread which
may attempt to find the taskprocessor has to wait.

ASTERISK-25295

Change-Id: Icb842db82fe1cf238da55df92e95938a4419377c
(cherry picked from commit a676ba2aad5525926ae31b8317b95ae52cbbabbb)

diff --git a/main/taskprocessor.c b/main/taskprocessor.c
index 5fbbca571d2d5171193263d4bd43f515c12ce3f8..ad471a8adbbd2ddac1a8c3f1a42ed64deb37a4b8 100644 (file)
--- a/main/taskprocessor.c
+++ b/main/taskprocessor.c
@@ -692,15 +692,25 @@ void *ast_taskprocessor_unreference(struct ast_taskprocessor *tps)
                return NULL;
        }
 
+       /* To prevent another thread from finding and getting a reference to this
+        * taskprocessor we hold the singletons lock. If we didn't do this then
+        * they may acquire it and find that the listener has been shut down.
+        */
+       ao2_lock(tps_singletons);
+
        if (ao2_ref(tps, -1) > 3) {
+               ao2_unlock(tps_singletons);
                return NULL;
        }
+
        /* If we're down to 3 references, then those must be:
         * 1. The reference we just got rid of
         * 2. The container
         * 3. The listener
         */
-       ao2_unlink(tps_singletons, tps);
+       ao2_unlink_flags(tps_singletons, tps, OBJ_NOLOCK);
+       ao2_unlock(tps_singletons);
+
        listener_shutdown(tps->listener);
        return NULL;
 }