AST-2016-002 chan_sip.c: Fix retransmission timeout integer overflow.

Setting the sip.conf timert1 value to a value higher than 1245 can cause
an integer overflow and result in large retransmit timeout times.  These
large timeout times hold system file descriptors hostage and can cause the
system to run out of file descriptors.

NOTE: The default sip.conf timert1 value is 500 which does not expose the
vulnerability.

* The overflow is now detected and the previous timeout time is
calculated.

ASTERISK-25397 #close
Reported by: Alexander Traud

Change-Id: Ia7231f2f415af1cbf90b923e001b9219cff46290

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 500aeb7854a28a68ec4d2699ca075ca9813a9f6a..06ea5333bda9f4e6b7f8a4973c46801330a1bf66 100644 (file)
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -3965,6 +3965,13 @@ static int retrans_pkt(const void *data)
                        }
 
                        /* For non-invites, a maximum of 4 secs */
+                       if (INT_MAX / pkt->timer_a < pkt->timer_t1) {
+                               /*
+                                * Uh Oh, we will have an integer overflow.
+                                * Recalculate previous timeout time instead.
+                                */
+                               pkt->timer_a = pkt->timer_a / 2;
+                       }
                        siptimer_a = pkt->timer_t1 * pkt->timer_a;      /* Double each time */
                        if (pkt->method != SIP_INVITE && siptimer_a > 4000) {
                                siptimer_a = 4000;