]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
res_sorcery_realtime.c: Fix crash from NULL sorcery object type. 99/1699/1
authorRichard Mudgett <rmudgett@digium.com>
Mon, 23 Nov 2015 20:27:27 +0000 (14:27 -0600)
committerRichard Mudgett <rmudgett@digium.com>
Mon, 23 Nov 2015 20:42:31 +0000 (14:42 -0600)
If the sorcery object type is not found a NULL is returned.
Unfortunately, sorcery_realtime_filter_objectset() will crash after
complaining about not finding the object type and saying to expect errors.

* Use ao2_cleanup() instead of ao2_ref() to prevent the crash.

ASTERISK-25165
Reported by Corey Farrell

Change-Id: Ic3b64453ea3058cb68d5c26d97d4fe7b8eea2e97

res/res_sorcery_realtime.c

index fc22170a57618fda1207ea5ba43f7ca669f4cc8a..3412b92cc934e2feac483b62915acbd5f0c5d90f 100644 (file)
@@ -142,7 +142,7 @@ static struct ast_variable *sorcery_realtime_filter_objectset(struct ast_variabl
                }
        }
 
-       ao2_ref(object_type, -1);
+       ao2_cleanup(object_type);
 
        return objectset;
 }