srv: Fix crash when ast_srv_lookup is used and 0 records are returned.

When performing an SRV lookup using the ast_srv_lookup function it
did not properly handle the situation where 0 records are returned.
If this happened it would wrongly assume that at least one record
was present.

This change fixes the code so it will exit early if an error occurs
or if 0 records are returned.

ASTERISK-26772
patches:
  srv_lookup.patch submitted by nappsoft (license 6822)

Change-Id: I09b19081c74e0ad11c12bf54a257243b1bcb2351

diff --git a/main/srv.c b/main/srv.c
index ef073a5178580c043c605e0b8c4e2244efbd5f6c..cedad7363f2e7c407ddc9b4aaa68d1021f191488 100644 (file)
--- a/main/srv.c
+++ b/main/srv.c
@@ -209,7 +209,8 @@ int ast_srv_lookup(struct srv_context **context, const char *service, const char
                }
                AST_LIST_HEAD_INIT_NOLOCK(&(*context)->entries);
 
-               if ((ast_search_dns(*context, service, C_IN, T_SRV, srv_callback)) < 0) {
+               if (((ast_search_dns(*context, service, C_IN, T_SRV, srv_callback)) < 1) ||
+                       AST_LIST_EMPTY(&(*context)->entries)) {
                        ast_free(*context);
                        *context = NULL;
                        return -1;