Pacify Coverity (CID #1680659 and #1680658)

Coverity doesn't appear to look inside state_entry_create to see that it
leaves the mutex unlocked on failure.

diff --git a/src/lib/server/state.c b/src/lib/server/state.c
index 68f3b016244739c912af10752cc409cea84d7e2b..ccdb6204107376df20643bcc8da351c1b775d9ce 100644 (file)
--- a/src/lib/server/state.c
+++ b/src/lib/server/state.c
@@ -868,6 +868,14 @@ int fr_state_store(fr_state_tree_t *state, request_t *request)
        if (!entry) {
                talloc_free(request_state_replace(request, state_ctx));
                request_data_restore(request, &data);   /* Put it back again */
+
+#ifdef __COVERITY__
+               /*
+                *  Coverity doesn't see that state_entry_create releases
+                *  the lock on failure
+                */
+               PTHREAD_MUTEX_UNLOCK(&state->mutex)
+#endif
                return -1;
        }