]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
build: Add "basebranch" to .gitreview development/16/geolocation
authorGeorge Joseph <gjoseph@digium.com>
Wed, 26 Jan 2022 13:56:15 +0000 (06:56 -0700)
committerGeorge Joseph <gjoseph@digium.com>
Tue, 28 Jun 2022 14:52:38 +0000 (08:52 -0600)
If you have a development branch for a major project that
will receive gerrit reviews it'll probably be named something
like "development/16/newproject".  That will necessitate setting
"defaultbranch=development/16/newproject" in .gitreview.  The
make_version script uses that variable to construct the asterisk
version however, which results in versions like
"GIT-development/16/newproject-ee582a8c7b" which is probably not
what you want.  Worse, since the download_externals script uses
make_version to construct the URL to download the binary codecs
or DPMA.  Since it's expecting a simple numeric version, the
downloads will fail.

To get this to work, a new variable "basebranch" has been added
to .gitreview and make_version has been updated to use that instead
of defaultversion:

.gitreview:
defaultbranch=development/16/myproject
basebranch=16

Now git-review will send the reviews to the proper branch
(development/16/myproject) but the version will still be
constructed using the simple branch number (16).

If "basebranch" is missing from .gitreview, make_version will
fall back to using "defaultbranch".

Change-Id: I2941a3b21e668febeb6cfbc1a7bb51a67726fcc4

.gitreview

index a233c590b0f9467f2c4fa38ce8495bab3a5ada64..3a5478c7889648d439063826de808d0e2db2db8c 100644 (file)
@@ -1,5 +1,5 @@
 [gerrit]
-defaultbranch=16
+defaultbranch=development/16/geolocation
 basebranch=16
 #
 # Intentional padding to ensure it is possible to point a commit