Address some review comments

I added moment.isImmutable and fixed unnecessary cloning.

diff --git a/src/lib/units/offset.js b/src/lib/units/offset.js
index e29f2cae4add61fbd029e640acba3bc1c3c95401..03d3bd8e7ecb53f98cb7c7bdc17da9f4119a3d2b 100644 (file)
--- a/src/lib/units/offset.js
+++ b/src/lib/units/offset.js
@@ -203,8 +203,8 @@ export function hasAlignedHourOffset (input) {
 
 export function isDaylightSavingTime () {
     return (
-        this.utcOffset() > new Moment(this).month(0).utcOffset() ||
-        this.utcOffset() > new Moment(this).month(5).utcOffset()
+        this.utcOffset() > this.month(0).utcOffset() ||
+        this.utcOffset() > this.month(5).utcOffset()
     );
 }
 

diff --git a/src/moment.js b/src/moment.js
index d810e2a6a9a577c29272f620fa10006504764462..feb8cedd70737c9b01aa8280cbe5187c621d3e65 100644 (file)
--- a/src/moment.js
+++ b/src/moment.js
@@ -7,6 +7,7 @@
 import { hooks as moment, setHookCallback } from './lib/utils/hooks';
 
 moment.version = '2.18.1';
+moment.isImmutable = true;
 
 import {
     min,