]> git.ipfire.org Git - people/jschlag/ipfire-2.x.git/commitdiff
fix assert in test improve_network_startup_step_2
authorJonatan Schlag <jonatan.schlag@ipfire.org>
Sat, 20 Apr 2024 14:36:13 +0000 (14:36 +0000)
committerJonatan Schlag <jonatan.schlag@ipfire.org>
Sat, 24 Aug 2024 12:14:16 +0000 (12:14 +0000)
Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org>
tests/src/scripts/readhash/test.sh

index 9d7ed26e3dbed9f7b96b2b933980c6e6d9ce2936..da4f7343face3b92b5728b5e475b1b69093370be 100755 (executable)
@@ -7,7 +7,7 @@ ROOT="$(readlink -f "${SCRIPT_PATH}/../../../..")"
 assert() {
        local assertion="$@"
 
-       if ! ${assertion} ; then
+       if ! "$@" ; then
                # End the program here
                echo "Assertion failed: ${assertion}"
                exit 1
@@ -18,8 +18,6 @@ assert() {
 
 var_has_value() {
        [[ "${!1}" == "${2}" ]]
-       echo "test ${!1}"
-       echo "test2 ${2}"  
 }
 
 chmod +x "${ROOT}/src/scripts/readhash"
@@ -32,8 +30,10 @@ chmod -x "${ROOT}/src/scripts/readhash"
 echo "'${BLUE_DEV}'"
 assert var_has_value "RED_DHCP_HOSTNAME" "ipfire"
 assert var_has_value "GREEN_DEV" "green0"
-assert var_has_value "BLUE_DEV" 'blue0 net0'
+assert var_has_value "BLUE_DEV" "blue0 net0"
 
 echo $BLUE_DEV
 
 
+
+