]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
Fix Coverity issue in SMTP output 1196/head
authorVictor Julien <victor@inliniac.net>
Fri, 31 Oct 2014 13:56:14 +0000 (14:56 +0100)
committerVictor Julien <victor@inliniac.net>
Fri, 31 Oct 2014 13:56:14 +0000 (14:56 +0100)
** CID 1250327:  Uninitialized pointer read  (UNINIT)
/src/output-json-email-common.c: 117 in JsonEmailLogJson()
/src/output-json-email-common.c: 139 in JsonEmailLogJson()

src/output-json-email-common.c

index 5b1e19f4199a14d0ba40fb493ba81f82e092653b..f12a0e1812272a8998b3cd191b906cdd41a6bf43 100644 (file)
@@ -114,7 +114,7 @@ static TmEcode JsonEmailLogJson(JsonEmailLogThread *aft, json_t *js, const Packe
             if (field != NULL) {
                 json_t *js_to = json_array();
                 if (likely(js_to != NULL)) {
-                    char *savep;
+                    char *savep = NULL;
                     char *p;
                     to_line = BytesToString((uint8_t *)field->value,
                                             (size_t)field->value_len);
@@ -136,7 +136,7 @@ static TmEcode JsonEmailLogJson(JsonEmailLogThread *aft, json_t *js, const Packe
             if (field != NULL) {
                 json_t *js_cc = json_array();
                 if (likely(js_cc != NULL)) {
-                    char *savep;
+                    char *savep = NULL;
                     char *p;
                     cc_line = BytesToString((uint8_t *)field->value,
                                             (size_t)field->value_len);