]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
Fix a fix: defrag OOM condition 1294/head
authorVictor Julien <victor@inliniac.net>
Fri, 12 Dec 2014 17:20:24 +0000 (18:20 +0100)
committerVictor Julien <victor@inliniac.net>
Thu, 15 Jan 2015 10:35:07 +0000 (11:35 +0100)
** CID 1257764:  Dereference after null check  (FORWARD_NULL)
/src/defrag.c: 291 in Defrag4Reassemble()

** CID 1257763:  Dereference after null check  (FORWARD_NULL)
/src/defrag.c: 409 in Defrag6Reassemble()

In the error case 'rp' can be both NULL or non-NULL.

src/defrag.c

index 71225b8da9f39c26988e9be766fe0a0f8d9d03c7..f005ade7de37476fb2aa539e99cadbca32ab528f 100644 (file)
@@ -358,7 +358,8 @@ done:
 error_remove_tracker:
     tracker->remove = 1;
     DefragTrackerFreeFrags(tracker);
-    PacketFreeOrRelease(rp);
+    if (rp != NULL)
+        PacketFreeOrRelease(rp);
     return NULL;
 }
 
@@ -480,7 +481,8 @@ done:
 error_remove_tracker:
     tracker->remove = 1;
     DefragTrackerFreeFrags(tracker);
-    PacketFreeOrRelease(rp);
+    if (rp != NULL)
+        PacketFreeOrRelease(rp);
     return NULL;
 }