cf_pair_dup(): be 'NOT NULL' to prevent SEGV

diff --git a/src/main/conffile.c b/src/main/conffile.c
index 855c0bb32ab943c8f7a9e47e2626cc21952e250f..4ea95350d86947c18776779decbf395bf1333e8c 100644 (file)
--- a/src/main/conffile.c
+++ b/src/main/conffile.c
@@ -568,7 +568,7 @@ CONF_PAIR *cf_pair_dup(CONF_SECTION *parent, CONF_PAIR *cp)
        /*
         *      Avoid mallocs if possible.
         */
-       if (!cp->item.filename || (strcmp(parent->item.filename, cp->item.filename) == 0)) {
+       if (!cp->item.filename || (parent->item.filename && !strcmp(parent->item.filename, cp->item.filename))) {
                new->item.filename = parent->item.filename;
        } else {
                new->item.filename = talloc_strdup(new, cp->item.filename);