Fix memory leak on invalid dhcp packet

diff --git a/src/modules/proto_dhcp/dhcp.c b/src/modules/proto_dhcp/dhcp.c
index 2754ccd2da3e42244dc768bb341e5c50bca2d1b5..204f87ad9d6223c65e2ac9cf2cf6e0648c29c8c1 100644 (file)
--- a/src/modules/proto_dhcp/dhcp.c
+++ b/src/modules/proto_dhcp/dhcp.c
@@ -877,6 +877,7 @@ ssize_t fr_dhcp_decode_options(TALLOC_CTX *ctx, VALUE_PAIR **out, uint8_t const
                if ((a_p + a_len) > q) {
                        fr_strerror_printf("Length field value of option %u is incorrect.  "
                                           "Got %u bytes, expected <= %zu bytes", p[0], p[1], q - a_p);
+                       fr_pair_list_free(out);
                        return -1;
                }