dnsdist: Fix performance inefficiencies reported by Coverity

Reported by Coverity as 414759 and 414760:
> Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)

diff --git a/pdns/dnsdistdist/doh3.cc b/pdns/dnsdistdist/doh3.cc
index f24e66c878924347fa1ae1d0797204126cb2faf1..d5216aa640c9e8dfa891393dcfd95a98e956de7c 100644 (file)
--- a/pdns/dnsdistdist/doh3.cc
+++ b/pdns/dnsdistdist/doh3.cc
@@ -439,7 +439,7 @@ static std::optional<std::reference_wrapper<H3Connection>> createConnection(DOH3
     quiche_conn_set_keylog_path(quicheConn.get(), config.df->d_quicheParams.d_keyLogFile.c_str());
   }
 
-  auto conn = H3Connection(peer, quicheConfig, std::move(quicheConn));
+  auto conn = H3Connection(peer, std::move(quicheConfig), std::move(quicheConn));
   auto pair = config.d_connections.emplace(serverSideID, std::move(conn));
   return pair.first->second;
 }

diff --git a/pdns/dnsdistdist/doq.cc b/pdns/dnsdistdist/doq.cc
index f3f0b40e469dc3e25665c3e2c585d5ef75a3d336..247b67a00447f98aa028bd35525f1bde4ce08a38 100644 (file)
--- a/pdns/dnsdistdist/doq.cc
+++ b/pdns/dnsdistdist/doq.cc
@@ -356,7 +356,7 @@ static std::optional<std::reference_wrapper<Connection>> createConnection(DOQSer
     quiche_conn_set_keylog_path(quicheConn.get(), config.df->d_quicheParams.d_keyLogFile.c_str());
   }
 
-  auto conn = Connection(peer, quicheConfig, std::move(quicheConn));
+  auto conn = Connection(peer, std::move(quicheConfig), std::move(quicheConn));
   auto pair = config.d_connections.emplace(serverSideID, std::move(conn));
   return pair.first->second;
 }