Fix getsockname() call in Windows localaddr

When querying local IP addresses, local_addr_fallback_kludge() is
called on Windows if gethostname() or gethostbyname() fails.  This
function's call to getsockname() erroneously passes a small integer as
the third argument instead of a pointer, likely causing a process
crash.  This bug has been present since 1.1, but is rarely encountered
due to the rarity of requests for addressful tickets.  Fix it.

[ghudson@mit.edu: rewrote commit message]

ticket: 9171 (new)

diff --git a/src/lib/krb5/os/localaddr.c b/src/lib/krb5/os/localaddr.c
index 4c734349836fa95b0edec29aaba4fb6b55738034..73dec6af25e12de1a6add4b809a36046e75f5860 100644 (file)
--- a/src/lib/krb5/os/localaddr.c
+++ b/src/lib/krb5/os/localaddr.c
@@ -1437,7 +1437,7 @@ static struct hostent *local_addr_fallback_kludge(void)
     if (err == SOCKET_ERROR)
         return NULL;
 
-    err = getsockname(sock, (LPSOCKADDR) &addr, (int *) size);
+    err = getsockname(sock, (LPSOCKADDR) &addr, &size);
     if (err == SOCKET_ERROR)
         return NULL;