]> git.ipfire.org Git - thirdparty/krb5.git/commitdiff
Fix kdb5_util ark with no -e option 1427/head
authorGreg Hudson <ghudson@mit.edu>
Fri, 18 Apr 2025 06:59:33 +0000 (02:59 -0400)
committerGreg Hudson <ghudson@mit.edu>
Fri, 25 Apr 2025 04:39:40 +0000 (00:39 -0400)
Avoid passing NULL to krb5_string_to_keysalt() in add_random_key().
When add_random_key() was first written, krb5_string_to_keysalts() did
nothing on a null string input.  After commit
3576bd662be9b7cc2cca97065fe467e745542b69 it calls strdup(NULL) and
crashes.

src/kadmin/dbutil/kdb5_util.c

index 88218dba740abd188cd7ef63d2f48a1e173cc14f..96b4a2571df5d108ede633e69b89ae54159225c9 100644 (file)
@@ -522,7 +522,7 @@ add_random_key(int argc, char **argv)
 
     int free_keysalts;
     char *me = progname;
-    char *ks_str = NULL;
+    char *ks_str = "";
     char *pr_str;
     krb5_keyblock *tmp_mkey;