Promtool may return 3 because of the "_total" suffix warnings

Co-authored-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

diff --git a/regression-tests.dnsdist/test_Prometheus.py b/regression-tests.dnsdist/test_Prometheus.py
index b41ce956b80cd9d2f173799efa82d2afa19b287e..57e5cc06576eca5b115f9312c5a99da65760f826 100644 (file)
--- a/regression-tests.dnsdist/test_Prometheus.py
+++ b/regression-tests.dnsdist/test_Prometheus.py
@@ -94,7 +94,7 @@ class TestPrometheus(DNSDistTest):
         except subprocess.CalledProcessError as exc:
             raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, process.output))
 
-        # promtool returns 3 because of the "_total" suffix warnings
+        # promtool may return 3 because of the "_total" suffix warnings
         if not process.returncode in [0, 3]:
           raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, output))
 

diff --git a/regression-tests.ixfrdist/test_Stats.py b/regression-tests.ixfrdist/test_Stats.py
index a8d4e69d41320ecb5ff76a9f6f006a066041e8fb..bc1bf3d74dc3e974cf634ff226319f6c9a2d70f3 100644 (file)
--- a/regression-tests.ixfrdist/test_Stats.py
+++ b/regression-tests.ixfrdist/test_Stats.py
@@ -60,7 +60,7 @@ webserver-address: %s
         except subprocess.CalledProcessError as exc:
             raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, process.output))
 
-        # promtool returns 3 because of the "_total" suffix warnings
+        # promtool may return 3 because of the "_total" suffix warnings
         if not process.returncode in [0, 3]:
           raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, output))
 

diff --git a/regression-tests.recursor-dnssec/test_Prometheus.py b/regression-tests.recursor-dnssec/test_Prometheus.py
index a618ae4db49eaf7d5f2cea33872cc09a82a9be24..d826fd31054eb5396478c85ca9b9f77773213544 100644 (file)
--- a/regression-tests.recursor-dnssec/test_Prometheus.py
+++ b/regression-tests.recursor-dnssec/test_Prometheus.py
@@ -29,7 +29,7 @@ class RecPrometheusTest(RecursorTest):
         except subprocess.CalledProcessError as exc:
             raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, process.output))
 
-        # promtool returns 3 because of the "_total" suffix warnings
+        # promtool may return 3 because of the "_total" suffix warnings
         if not process.returncode in [0, 3]:
           raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, output))