Fix dns.name.Name.to_text()

Fix dns.name.Name.to_text(), so root is displayed properly.

diff --git a/dns/name.py b/dns/name.py
index 5d017a35d53799f9984d34ac9a91a245964929ca..c30e58e0da20130d4f8802b9167b3127cffaa220 100644 (file)
--- a/dns/name.py
+++ b/dns/name.py
@@ -387,7 +387,7 @@ class Name(object):
 
         if len(self.labels) == 0:
             return u'@'
-        if len(self.labels) == 1 and self.labels[0] == '':
+        if len(self.labels) == 1 and self.labels[0] == b'':
             return u'.'
         if omit_final_dot and self.is_absolute():
             l = self.labels[:-1]

diff --git a/tests/test_name.py b/tests/test_name.py
index 645cf75918c9070280abcf2fff6f0cffb9aa7820..581459ac21713ad48e0e103e69fbae9c192efcd5 100644 (file)
--- a/tests/test_name.py
+++ b/tests/test_name.py
@@ -242,6 +242,14 @@ class NameTestCase(unittest.TestCase):
         t = n.to_text()
         self.assertEqual(t, br'x80\.bar')
 
+    def testToText10(self):
+        t = dns.name.empty.to_unicode()
+        self.assertEqual(t, '@')
+
+    def testToText11(self):
+        t = dns.name.root.to_unicode()
+        self.assertEqual(t, '.')
+
     def testSlice1(self):
         n = dns.name.from_text(r'a.b.c.', origin=None)
         s = n[:]