]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
uboot-tools: remove uneeded syncconfig 18515/head
authorRobert Marko <robimarko@gmail.com>
Thu, 17 Apr 2025 11:20:06 +0000 (13:20 +0200)
committerRobert Marko <robimarko@gmail.com>
Fri, 18 Apr 2025 11:22:12 +0000 (13:22 +0200)
During envtools conversion to the generic uboot-tools package, a syncconfig
call was added to the configure step which was previously not there.

We received multiple spourious reports that now envtools were failing to
build [1], but it was not reproducible.

However, it seems that this could easily be reproduced on MacOS 15 and
somehow that syncconfig call is breaking build by Makefile.autoconf not
being executed and thus no "include/config.h" is generated.

So, since this call was not previously there and U-Boot will actually do
syncconfig on its own when needed lets drop it.

[1] https://github.com/openwrt/openwrt/commit/293d5f1366e099cc343a3fc8a6f936ab27bcad6a#commitcomment-154347516

Link: https://github.com/openwrt/openwrt/pull/18515
Signed-off-by: Robert Marko <robimarko@gmail.com>
package/boot/uboot-tools/Makefile

index 9fa680c97c86435ad5186cc55d505547c1797d6f..f4655373423eaee646da52764aa45a369e44b33b 100644 (file)
@@ -71,7 +71,6 @@ endef
 
 define Build/Configure
        $(call Build/Compile/Default,tools-only_defconfig)
-       $(call Build/Compile/Default,syncconfig)
        $(SED) 's/CONFIG_TOOLS_LIBCRYPTO=y/# CONFIG_TOOLS_LIBCRYPTO is not set/' $(PKG_BUILD_DIR)/.config
        $(SED) 's/CONFIG_TOOLS_KWBIMAGE=y/# CONFIG_TOOLS_KWBIMAGE is not set/' $(PKG_BUILD_DIR)/.config
 endef