]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
kernel: mtk_bmt: counteracting calloc-transposed-args compiler warning 18701/head
authorMieczyslaw Nalewaj <namiltd@yahoo.com>
Sun, 4 May 2025 09:32:57 +0000 (11:32 +0200)
committerRobert Marko <robimarko@gmail.com>
Tue, 13 May 2025 20:07:11 +0000 (22:07 +0200)
For kernel 6.12 there is a warning causing an error:
drivers/mtd/nand/mtk_bmt_v2.c: In function 'mtk_bmt_get_mapping_mask':
drivers/mtd/nand/mtk_bmt_v2.c:307:31: error: 'kmalloc_array_noprof' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
  307 |         used = kcalloc(sizeof(unsigned long), BIT_WORD(bmtd.bmt_blk_idx) + 1, GFP_KERNEL);
      |                               ^~~~~~~~

Swapping the arguments solves the problem.

Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com>
Link: https://github.com/openwrt/openwrt/pull/18701
Signed-off-by: Robert Marko <robimarko@gmail.com>
target/linux/generic/files/drivers/mtd/nand/mtk_bmt_v2.c

index 6b06948c0f45fa16bc1a3a751d2d35bcee21f914..a17b7290260bebeffad2689b59a26f71778efa04 100644 (file)
@@ -304,7 +304,7 @@ mtk_bmt_get_mapping_mask(void)
        unsigned long *used;
        int i, k;
 
-       used = kcalloc(sizeof(unsigned long), BIT_WORD(bmtd.bmt_blk_idx) + 1, GFP_KERNEL);
+       used = kcalloc(BIT_WORD(bmtd.bmt_blk_idx) + 1, sizeof(unsigned long), GFP_KERNEL);
        if (!used)
                return NULL;