]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
mvebu: gl-mv1000: fix sdhci1 controller 20378/head
authorMikhail Zadorozhnyi <zador.blood.stained+git@protonmail.com>
Sat, 11 Oct 2025 09:00:06 +0000 (12:00 +0300)
committerHauke Mehrtens <hauke@hauke-m.de>
Fri, 12 Dec 2025 00:04:07 +0000 (01:04 +0100)
GL-MV1000 external SD controller was broken by a recent kernel update
between OpenWRT releases 24.10.2 and 24.10.3 due to a mistake in Device
Tree: "regulator-gpio" was defined without required "gpios" property.

Since "no-1-8-v" property is also defined for this controller
a switchable vqmmc-supply regulator performs no function - a fixed 3.3V
IO voltage will always be used.

This regulator definition was probably added by mistake from a Device
Tree from another device.

Remove incomplete vcc_sd_reg1 regulator definition to fix this issue.

Issue discussion for reference: openwrt/openwrt#20309

Upstream commit: 6f2325b23d2cfa28099c26c299ae774625f1872b
Signed-off-by: Mikhail Zadorozhnyi <zador.blood.stained+git@protonmail.com>
Link: https://github.com/openwrt/openwrt/pull/20378
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
target/linux/mvebu/files-6.6/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts

index e098ede75f8b5035bbcfee2b96212de86985722e..2ad9660e48513ede46a8ed3fe0fd50474561186b 100644 (file)
                reg = <0x00000000 0x00000000 0x00000000 0x20000000>;
        };
 
-       vcc_sd_reg1: regulator {
-               compatible = "regulator-gpio";
-               regulator-name = "vcc_sd1";
-               regulator-min-microvolt = <1800000>;
-               regulator-max-microvolt = <3300000>;
-               regulator-boot-on;
-
-               gpios-states = <0>;
-               states = <1800000 0x1
-                       3300000 0x0>;
-               enable-active-high;
-       };
-
        keys {
                compatible = "gpio-keys";
 
        cd-gpios = <&gpionb 17 GPIO_ACTIVE_LOW>;
        marvell,pad-type = "sd";
        no-1-8-v;
-       vqmmc-supply = <&vcc_sd_reg1>;
        status = "okay";
 };