]> git.ipfire.org Git - thirdparty/mkosi.git/commitdiff
Only set extra_groups for mkdir() if we were invoked as root 2543/head
authorDaan De Meyer <daan.j.demeyer@gmail.com>
Thu, 21 Mar 2024 12:35:01 +0000 (13:35 +0100)
committerDaan De Meyer <daan.j.demeyer@gmail.com>
Thu, 21 Mar 2024 13:13:05 +0000 (14:13 +0100)
The extra groups of the user are not mapped into the user namespace
we create and as such can't be set when invoking a subprocess if
we weren't invoked as root.

mkosi/user.py

index 34a9a8a7a6639d3fad9bbb541fdefeb84eb0ba28..4437fd5e71b6be4a2a5fad581e7b482af5878855 100644 (file)
@@ -76,7 +76,7 @@ class INVOKING_USER:
             ["mkdir", "--parents", path],
             user=cls.uid if cond else os.getuid(),
             group=cls.gid if cond else os.getgid(),
-            extra_groups=cls.extra_groups() if cond else None,
+            extra_groups=cls.extra_groups() if cls.invoked_as_root and cond else None,
         )
         return path