]> git.ipfire.org Git - thirdparty/tornado.git/commitdiff
test: Use default timeouts in sigchild test 2880/head
authorBen Darnell <ben@cockroachlabs.com>
Sat, 20 Jun 2020 16:52:44 +0000 (12:52 -0400)
committerBen Darnell <ben@cockroachlabs.com>
Sat, 20 Jun 2020 16:52:44 +0000 (12:52 -0400)
The 1s timeout used here has become flaky with the introduction of a
sleep (before the timeout even starts).

tornado/test/process_test.py

index 1f299202481870dfe5c4aa8e648d97746c852ae1..2178b34f78fefac84656a82017df405e1a6fa026 100644 (file)
@@ -235,7 +235,7 @@ class SubprocessTest(AsyncTestCase):
 
         os.kill(subproc.pid, signal.SIGTERM)
         try:
-            ret = self.wait(timeout=1.0)
+            ret = self.wait()
         except AssertionError:
             # We failed to get the termination signal. This test is
             # occasionally flaky on pypy, so try to get a little more
@@ -246,7 +246,7 @@ class SubprocessTest(AsyncTestCase):
             fut = subproc.stdout.read_until_close()
             fut.add_done_callback(lambda f: self.stop())  # type: ignore
             try:
-                self.wait(timeout=1.0)
+                self.wait()
             except AssertionError:
                 raise AssertionError("subprocess failed to terminate")
             else: