]> git.ipfire.org Git - thirdparty/zstd.git/commitdiff
Trigger Release Artifact Generation on Publish 3018/head
authorW. Felix Handte <w@felixhandte.com>
Thu, 20 Jan 2022 22:36:28 +0000 (17:36 -0500)
committerW. Felix Handte <w@felixhandte.com>
Thu, 20 Jan 2022 22:36:28 +0000 (17:36 -0500)
We previously triggered release artifact generation on release creation. We
sometimes observed that the action failed to run. I hypothesized that we were
hitting rate limiting or something. I just stumbled across [this documentat-
ion](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release), which says:

> Note: Workflows are not triggered for the `created`, `edited`, or `deleted`
> activity types for draft releases. When you create your release through the
> GitHub browser UI, your release may automatically be saved as a draft.

This must have been what was happening. This commit therefore changes the
trigger to the `published` activity. This should be more reliable.

This does have the unfortunate side effect that artifacts won't be generated
or attached until *after* the release has been published, which is what I was
trying to avoid by using the `created` activity. Oh well.

.github/workflows/publish-release-artifacts.yml

index 952cb26b7e9f8102aec9ae4f891a1b1be99049e8..a87a75efa493cb99d4be0b446f653eb7bd2058cd 100644 (file)
@@ -3,7 +3,7 @@ name: publish-release-artifacts
 on:
   release:
     types:
-      - created
+      - published
 
 jobs:
   publish-release-artifacts: